Skip to content

V2 by default #19333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: sycl
Choose a base branch
from
Draft

V2 by default #19333

wants to merge 2 commits into from
+62 −172

Conversation

igchor
Copy link
Member

@igchor igchor commented Jul 7, 2025

No description provided.

igchor added 2 commits July 7, 2025 19:13
@igchor
[SYCL][UR] Unify logging and leak checking for L0 v1 and v2
c099481
@igchor
[SYCL][UR] Make v2 adapter default for BMG and newer
b1877ae 
Whenever we detect ANY device newer than BMG on
the platform we will use V2, otherwise we will use V1.

The default behavior can still be overwritten by setting
SYCL_UR_USE_LEVEL_ZERO_V2=1 to use V2 adapter or
SYCL_UR_USE_LEVEL_ZERO_V2=0 to use V1 adapter.
@igchor igchor temporarily deployed to WindowsCILock July 7, 2025 21:18 — with GitHub Actions Inactive
pbalcer
pbalcer reviewed Jul 8, 2025
View reviewed changes
Copy link
Contributor

@pbalcer pbalcer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm in general. But I think this patch should also consolidate building v1/v2 under the same CMake flag. When this is merged, both .so files will be required for the runtime to function properly on all systems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbalcer pbalcer pbalcer left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igchor @pbalcer